Michael Ganss

Results 275 comments of Michael Ganss

IMO finding all the matching substrings and their locations is a fundamental feature of the Aho Corasick algorithm and a requirement for many use cases.

This ``` C# var ac = new AhoCorasickTree(new[] { "a", "ab", "bab", "bc", "bca", "c", "caa" }); var m = ac.Search("abccab").ToList(); ``` finds only "a", "ab", "bc", "a", "ab". Should...

Unfortunately, it's not easy to extend the algorithm to wildcards. Perhaps you could search for all the non-wildcard substrings of your patterns and then perform additional checks to see if...

- Saving nested objects is supported - There is no max depth - Collections are not supported out of the box (see #170, #134) Re collections you might also try...

This use case isn't currently supported. The closest is support for dynamic objects so you could pass a list of `ExpandoObject` (which implements `IDictionary`) to `Save()`. Still this necessitates that...

The invocation of the `Saving` event happens right before the workbook is written so I'm surprised the style gets overwritten: https://github.com/mganss/ExcelMapper/blob/efc3efdf2de04a4776c58f17fa21b8009074645c/ExcelMapper/ExcelMapper.cs#L1012-L1014 Have you already investigated where the overwriting occurs?

Thanks. TBH, I'm not a fan of the pseudo-syntax documentation for `Func` parameters. Is this used elsewhere? I'd prefer just regular text comments like it's used e.g. for the `predicate`...

I agree with you about the need to better document the Func's parameters. > Sorry, I do not understand what you mean here or where we should add those text...

Sorry for the late response. I'm hesitant to add another parameter to the `Save()` methods. I'd rather add an event that gets invoked just before the workbook is written. The...

You can have custom table styles can't you? If so, perhaps the builtin styles can become const strings.