Michael Ganss

Results 275 comments of Michael Ganss

Your suggestions sound very good to me. Perhaps this could be extended to all property types that implement `ICollection`, not only arrays. From the top of my hat this shouldn't...

No worries, we don't have any deadlines 😄 It's an interesting topic which I hadn't given much thought in this context (git's autocrlf options have been driving me mad every...

Can't verify right now but I think row numbers start at 0 in ExcelMapper while they start at 1 in Excel.

I'll leave it this way for now as this would be a major breaking change. POI also uses 0-based row numbering. ExcelMapper is admittedly inconsistent as column numbers are 1-based.

I can't repro the failure. The `MemoryStream`'s buffer is still available after it is closed. See this answer at StackOverflow: https://stackoverflow.com/a/3981274/1970064

No, this is not possible currently.

What's the use case for this? Numeric cells that are mapped to string properties should automatically get the formatted value now.

Sorry, I don't get it. The cells that are date formatted as "10-11" should be mapped to a string property using the format specified in the Excel sheet so you'll...

I'm hesitant on this. Not only would this be a breaking change, but it would require recompilation for all users. If I were faced with this change as a user,...