Yun Peng

Results 616 comments of Yun Peng

I think this change makes sense, but please wait until https://github.com/bazelbuild/bazel/pull/27379 is merged and resolve the potential conflicts. @Wyverald Feel free to also take a quick look to confirm the...

@bu3 Can you please rebase on the latest main branch? The presubmit now only passes with https://github.com/bazelbuild/bazel-central-registry/pull/4191

You can look at the BUILD file here: https://github.com/bazelbuild/bazel-central-registry/pull/4341/files#diff-216701f7f8d18c1907d2869789c08bbb00d2ac6561e2d3993d66b452d02a3667R255 I believe you just need to depend on the `@verilator` target.

Yeah, I agree this is more of an API change that specifically address JAX/XLA's needs, happy to wait for a more proper solution.

Currently we are resolving those test targets for sharding at https://github.com/bazelbuild/continuous-integration/blob/a1dfff1694bc39b07454d3d50cf2c2973c1308d5/buildkite/bazelci.py#L2270-L2279 @fweikert tried to switch to using cquery from query (EXP_USE_CQUERY), maybe that would help, but we probably encountered other...

Maybe we can also just bazel query to exclude `bazel query 'attr(target_compatible_with, "@platforms//os:windows", tests(//...))'`

I can try with Gemini

https://github.com/bazelbuild/continuous-integration/pull/2419

@fmeum Looks like there are still other test failures like `//tools/ctexplain:lib_test`

Also, please sync to HEAD, just in case there are new breaking tests.