Yun Peng
Yun Peng
grpc probably had the similar problem and we had to use REPO.bazel to inject this feature for it: https://github.com/bazelbuild/bazel-central-registry/blob/950587f0751aed12cb1bc2d7a3cb934afbad23ea/modules/grpc/1.76.0.bcr.1/patches/add_repo_bazel.patch
@pcjanzen Indeed it's probably not the best solution, feel free to send a proper fix to grpc.
According to https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1253 This flag is breaking almost all downstream projects, I believe it's the same for the wider community. If no active plan on migrating the ecosystem, I'll remove...
> What I am going for is, imho we should flip this flag soon (maybe Bazel 6.0?). This might be the gentle push for downstream projects to adapt to the...
@limdor The flag wasn't tested in the pipeline because the "migration-ready" was removed. I added it again let's see https://github.com/bazelbuild/bazel/pull/15374 will fix the failures.
From https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1253#01833aea-8848-4562-976c-916e87f33b6b, I can see at least TensorFlow is broken by this: ``` (08:59:35) ERROR: Traceback (most recent call last): File "C:/b/bk-windows-gclq/bazel-downstream-projects/tensorflow/tensorflow/tools/docs/BUILD", line 154, column 16, in data = glob(["**/create_model.md"]),...
> My proposal would be to try to get the PRs for the downstream projects where it sets allow_empty to true for the affected globs, and in the hypothetical case...
@limdor The list seems to track the progress of fixing Bazel itself? There are many downstream projects also broken, which should also be migrated first before flipping the flag: [https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1253](https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1253#01833aea-8848-4562-976c-916e87f33b6b)
@limdor Sure, as long as someone is actively working on this, I'm happy to enable the test!
@limdor Thank you so much!