Yun Peng

Results 566 comments of Yun Peng

Thanks! Waiting for @Wyverald to take a look!

I don't see any reason the RBE jobs have to build with Bazel 6.4.0 and ubuntu1604, please upgrade to Bazel 7.3.2 and ubuntu2204

I'm not sure which one is the Bazel 7 RBE job, but the for those RBE jobs, you should upgrade to `rbe_ubuntu2004`. If Bazel 6 is still supported, then we...

We should probably add `"minItems": 1` at https://github.com/bazelbuild/bazel-central-registry/blob/28b383561361478c560975f02db3776cd93e4ff5/metadata.schema.json#L35-L40 to make sure future modules are not missing this attribute? /cc @alexeagle

> Wouldn't this change break uploads of modules that have GitHub projects, but host their releases elsewhere? http url is also supported as source repo, but yeah, we should make...

@adzenith Basically, please make sure ``` python3 ./tools/bcr_validation.py --check=bzip2 --check=bazel_env.bzl --check=darts-clone --check=nasm --check=rules_cc --check=rules_jni --check=rules_libusb --check=rules_sh --check=sqlite3 --check=toolchains_musl ``` passes for source repo check after this change. The source repo...

Fixed in https://github.com/bazelbuild/bazel-central-registry/pull/3982

Yeah, Windows requires the path of the binary to run has to be a Windows style path. I believe why it succeeded locally is because we preprocess the arg0 (replacing...

OK, I did some debugging and found another place we made sure the first argument is a valid path to execute. https://github.com/bazelbuild/bazel/blob/ddc57b2cf3d291cf82e854f60bfbc3ed9a14b27b/src/main/java/com/google/devtools/build/lib/exec/local/LocalSpawnRunner.java#L367-L376 @ulfjack, from the blame history, you are the...

> If Bazel doesn't convert the paths correctly, every single such tool would have to do the translation, not just RBE. @ulfjack Do you want to help fixing the RemoteSpawnRunner?