Carlos Fuentes comments

Results 528 comments of


                                            Carlos Fuentes

Set-Cookie header gets concatenated in fetch if an interceptor is in place

I'd say we could align to always expect an array when it comes to multiple-value headers, pairing a bit with what's the expectation of `node:http#request`.

fix: ensure validation errors after async preValidation reach error handler (#6214)

Did you push your changes? I can still see the usage of `validateSchema`

Disposable decorated resources should be automatically closed on `onClose` hook.

This sounds like a good idea for a plugin that uses the `onClose` hook to dispose resources.

Custom bodyLimit is not taken into account, so fallback on default limit of 1MiB

Can you provide an [Minimum Reproducible Example](https://stackoverflow.com/help/minimal-reproducible-example) to support you better? Tried with the following sample and couldn't reproduce it: ```js const fastify = require('fastify')({ logger: true, bodyLimit: 5 *...

Custom bodyLimit is not taken into account, so fallback on default limit of 1MiB

I cannot see where are you setting the body limit here, but I'm guessing something is missed around those lines

Abortable tasks may share worker threads; aborting one task can terminate unrelated tasks

The report looks an AI generated content, and the bug is not reproducible at all; the way the abortable tasks are handled are not made in this way. I'd suggest...

Broken links in docs/docsify/sidebar.md – incorrect API doc URLs

I don't recall if that's on purpose; cannot remember if auto generated. cc: @Ethan-Arrowood

feat(#4230): Implement pingInterval for dispatching PING frames

@mcollina

feat(#4230): Implement pingInterval for dispatching PING frames

Done

Invalid HTTP2 headers should be recoverable

go for it