Carlos Fuentes

Results 528 comments of Carlos Fuentes

Oh well, that's a major bump you are doing, maybe there's something within your implementation that is not working anymore. Can you provide an [Minimum Reproducible Example](https://stackoverflow.com/help/minimal-reproducible-example)?

I see, I'd recommend tho to better upgrade to v16.14 or do not make the bump on Piscina until the Node version is fully upgraded on the application

I'm not really in sync with changing the behaviour to sync with other test runners. Overall the intention of `Undici` mocks seems to be as declarative as possible and scoped...

This seems due to the fact that you are attempting to pass as `workerData` a function that cannot be serialized by the structured clone algorithm; can you provide an [Minimum...

Hi @bellatrick! Not yet, but we are willing to invest in that; so far we are open to suggestions so happy to hear your thoughts. We can start with something...

Great! Then let's keep it here, feel free to open a PR to move things forward and let me know how I can be of support

> Just for completeness: This could slow down the response time by fastify on invalid json payloads by about 90%! I would actually recommend to think about my proposol above...

>with my suggested change: I'm ok with the suggestion; `secure-json-parse` seems to already remove stack trace upon parsing so the regression seems to be mostly due to error generation. I'd...

If @climba03003's suggestion has the same benefits, I'd say that his approach will be a good way to move forward

SGTM, it can be very beneficial, especially when attempting to apply limits to custom workflows or according to business logic