Carlos Fuentes

Results 528 comments of Carlos Fuentes

Would you like to send a PR for it? Do not forget to add tests

Hmm, the `RequestAborted` can be extended with a reason that helps identify what cause it; or even create a new one. Feel free to open a PR for that

Get what you mean, nevertheless I was referring to extend the `RequestAbortError` to enrich its context, without affecting the `reason` implementation. For undici, a request being aborted means an actual...

Indeed, tho for the use-case shared here, these timeouts (high level and not precise) fits better than an `AbortSignal`, given that the signal itself works better to control the flow...

The `RetryHandler` or Agent, can fully do that based on the errors thrown by the `headersTimeout` or the `requestTimeout`; these will be identified as potential errors and will attempt to...

Sure, I'm not disregarding that; its a limitation. My recommendation is for common situations and overall recommendation. For more narrowed use-cases like this one, it might be better to create...

This is not a bug per-se, but somehow an expected behavior; without the `type` the schema cannot infer the data primitive to serialize against, leading to this result. I advice...

This can be pretty interesting, we can gain some bit in performance. Tho the serialization/deserialization step might become the bottleneck isn't it? Or how do you propose to handle the...

What could be good defaults for this? I'm thinking here that, the a good portion of scenarios will be simple JSON (de)serialization or primitive values and having to guess them...

Hi @alinopower! Can you provide an [Minimum Reproducible Example](https://stackoverflow.com/help/minimal-reproducible-example) and which Piscina version are you using?