Carlos Fuentes

Results 528 comments of Carlos Fuentes

I see a possible overlap between #3998 and this issue, tho I believe they serve different purposes to solve different problems; so might be good to consider them a separated...

We will be able to help you better if you can isolate the problem as much as you can by providing an [Minimum Reproducible Example](https://stackoverflow.com/help/minimal-reproducible-example)

> @mcollina @KhafraDev @metcoder95 > > Is there not a better way to implement the debugLog? What do you mean? I think we can do a second iteration of `debuglog`,...

Let's seek to merge it and re-iterate over the debuglogs if needed in another PR

Under which platform are you using Piscina, and which version of Piscina? Can you also provide an [Minimum Reproducible Example](https://stackoverflow.com/help/minimal-reproducible-example)?

>onBodySent and onRequestSent are huge footguns. Remove it. (just wrap the body) SGTM, left some thoughts on the PR 👍 >interceptors are weird and overengineered. Remove it. (just wrap dispatchers)...

Sure, I can have something prepared for next week 👍

>If we consider undici major version, than maybe target llhttp 9 upgrade to the next branch?! I believe that yes, but also with the considerations from @mcollina

> ``` > const dispatch = [ > dispatch => (opts, handler) => dispatch(opts, new LogHandler(opts, { handler, dispatch })), > dispatch => (opts, handler) => dispatch(opts, new RedirectHandler(opts, {...

Yeah, I'll tackle it within that PR 👍