Ed Merks

Results 491 comments of Ed Merks

That is a difference. Why does dependency:get work without a property definition? Because that's not a "consumed pom"?

Have you ever looked at what people publish/dump to Maven central? It appears to me like it's "anything goes".

This one has some test failures but that doesn't look related to the changes. I'm not sure those failures are recorded as issues anywhere yet.

@elsazac Yes, this looks unrelated to the PR itself. @laeubi There is only this failure at the end: ![image](https://github.com/eclipse-platform/eclipse.platform.ui/assets/208716/c150079f-c496-4444-864d-c1d0bad5c364) I can't find anything earlier in the log with more clues...

Personally I prefer to see one commit that’s amended https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#creating-a-pull-request At some point there will need to be one commit with a good commit description.

Well, that probably means an enterprise secured environment also does not want to you allow virus scanning to be bypassed since this involved registry changes that are no doubt also...

The dialog and the preferences explain in quite a bit of detail: ![image](https://github.com/eclipse-platform/eclipse.platform.ui/assets/208716/085feca7-1a2a-4d37-8f9f-4441eb652e73) If you re-read it again carefully, is there something about that description that isn't entirely clear and...

Yes, handling the return value to detect permission failure would be a very good thing. I'm not sure if it's possible to determine the permission level without trying to execute...

There was a long, oh so very, very long, discussion about the dialog when it was being designed. 😱That would have been the best time to chime in and I...