Ed Merks

Results 491 comments of Ed Merks

I agree. Imagine 5 search dialogs open. Is that sensible? Maybe. What if you start two long-running searches at the same time? So let’s be careful and sensible when making...

> @merks Thanks for testing. Looks like each search type creates different dialog action objects. I made the dialog static now and hope it solves the problem without any side...

When testing, I would ensure that opening and closing and repeating that process works on each workbench window. (The code will need to test that the dialog it wants to...

Note that fDescriptors is kind of a map because it has an index and it know the descriptor and hence the ID. But I see there is some filtering involved...

I think the same kind of attention as is focused on find/replace but focused on the search view would be a better, though much bigger, time investment. Especially given that...

@Wittmaxi Yes this is a whole new "kettle of fish" as they say. So a whole new set of challenges, especially given that the search dialog can be extended. ![image](https://github.com/eclipse-platform/eclipse.platform.ui/assets/208716/ef5d8aa4-bb7b-41a5-ba2a-c3ff69fd922a)...

I’ve seen this problem too on Windows but it’s hard to reproduce. I thought maybe it was related to multi thread search.

I would love to fix it, if I could make it happen with some regularity. It's super annoying! And I always think "One of these days I'm going to make...

Sometimes the summary tells me different information. Here I've filtered to the deepest match. ![image](https://github.com/user-attachments/assets/3d8bc328-fdb7-46a5-9e22-57b6cf92e088) ![image](https://github.com/user-attachments/assets/85ba1797-53c8-4539-87ca-9f4528d364c6) Here I wonder that it's showing 37 of 42 which to me means it...

Which editor? What type of file are you editing?