eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard

Adding Javadoc

Open Sorna-Sarathi opened this issue 1 year ago • 1 comments

Added the Javadoc for the cleanUp() in CocoaDarkThemeProcessor.

Sorna-Sarathi avatar May 13 '24 13:05 Sorna-Sarathi

Test Results

 1 812 files  ±0   1 812 suites  ±0   1h 29m 35s :stopwatch: - 5m 47s  7 614 tests ±0   7 385 :white_check_mark:  - 1  228 :zzz: ±0  1 :x: +1  23 994 runs  ±0  23 244 :white_check_mark:  - 1  749 :zzz: ±0  1 :x: +1 

For more details on these failures, see this check.

Results for commit da4a3683. ± Comparison against base commit f9817287.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 13 '24 14:05 github-actions[bot]

To me, these failures seem to be infrastructure related- not related to the PR changes.

Are there known CI issues?

elsazac avatar May 21 '24 06:05 elsazac

@elsazac

Yes, this looks unrelated to the PR itself.

@laeubi

There is only this failure at the end:

image

I can't find anything earlier in the log with more clues...

merks avatar May 21 '24 07:05 merks

Looks like a bug in PDE API tools...

laeubi avatar May 21 '24 07:05 laeubi

Given the current freeze period, I will merge these changes once the development cycle reopens, as the test failures are unrelated to the changes.

elsazac avatar May 22 '24 06:05 elsazac

As mentioned in the "RC1 reminder" mail, "Ongoing changes to documentation, tests or examples do not require approval.”

mickaelistria avatar May 22 '24 07:05 mickaelistria