Hein Meling
Hein Meling
We should add a contribution guide to the readme. We could take inspiration from [quickfeed](https://github.com/quickfeed/quickfeed). We should also link to the markdown files in the doc folder, og integrate some...
## Summary Our current metrics flow is built around protobuf messages collected at worker nodes (clients and replicas) and sent to the experiment controller. This works well, but we should...
Fixes #262 This moves the `VerifySyncInfo` logic from the simple and aggregate timeout rules into a common logic on the `cert.Authority` struct, along with many other crypto verification methods (also...
Kauri's Begin method has a [DelayUntil](https://github.com/relab/hotstuff/blob/48e4d893397a306ab3fa2183ac2474f1a83fdb05/kauri/kauri.go#L97) call (on the master branch) with a `func()` as the event type. However, no event handler is registered for such an event type elsewhere...
See my TODO/NOTE comments below. This code will always return `true` for the `timeout`, unless `syncInfo` is missing both `TC` and `AggQC` (or the signatures fail to verify). This can't...
I have not investigated this, but it only occurred for two out of 2880 benchmark runs. It occurred for both old and new runs, and the issue is not consistent...
The current BLS12 implementation that we depend on is - https://github.com/kilic/bls12-381 There hasn't been any releases since 2021; we are using `v0.1.1-0.20210208205449-6045b0235e36` The repository was archived Dec 27, 2023. There...
_Originally posted by @leandernikolaus in https://github.com/relab/hotstuff/pull/221#discussion_r2403840827_ No, at this point, the replica is actually in between views. It stopped voting in one view but did not start the next view....
```proto message Signature { oneof Sig { ECDSASignature ECDSASig = 1; BLS12Signature BLS12Sig = 2; EDDSASignature EDDSASig = 3; } } ``` This is never used in Go code or...
This method: ```go func (chain *Blockchain) LocalGet(hash hotstuff.Hash) (*hotstuff.Block, bool) { ``` Since this already returns a pointer to a block, there is no need to also return a bool....