Hein Meling
Hein Meling
- [ ] Replace call to `getEnrollmentsByCourse` with call to `getEnrollmentsWithActivity`. - [ ] Delete `getEnrollmentsByCourse` - [ ] Rename `getEnrollmentsWithActivity` to `getEnrollmentsByCourse` (double check that this makes sense.) This...
```go // Get repositories within organization. GetRepositories(context.Context, *qf.Organization) ([]*Repository, error) ``` This method is only used in `GetOrganization()`, in a few tests, and in the `cmd/scm` tool, which isn't maintained....
The `deleteRepository` method is only use two times (here via `DeleteGroup`) ```go opt := &scm.RepositoryOptions{ ID: repo.GetScmRepositoryID(), } return sc.DeleteGroup(ctx, opt) ``` And here (via `RejectEnrollment`): ```go if err :=...
In `qf/assignment_test.go` we use test naming like this: ```go name: "Assignment:ScoreLimit=90:AutoApprove:IsGroupLab,Submission:UserId=15:Status=NONE:OldScore=0,NewScore:95", ``` We should replace this naming style with the Go test convention to use `/` instead of `:`. We...
We currently only use `slug.Make(opt.Name)` when looking up an organization (from the `scm`); at this point it might already be too late, since the organization has been created on GitHub...
Setting `oneof` fields in proto message types can be a pain. We could write a message constructor function that supports setting them for the most relevant types, i.e., those with...
We should ideally avoid accessing fields of protobuf messages directly; we should instead use the getter methods. Below is an example of a field accessed in two different ways in...
We should remove the excessive use of gorm unique index in our database schemas. See [this example](https://github.com/quickfeed/quickfeed/blob/1a2bac52a07d39f12b5d7f72e7b29c6c2911a1e4/qf/types.proto#L102). I believe we should only use one or two such unique indexes per...
Fixes #68