Hein Meling
Hein Meling
The `IDSet` is confusing for the reader and non-idiomatic Go: ```go // IDSet implements a set of replica IDs. It is used to show which replicas participated in some event....
We should take advantage of [The new Opaque API](https://opaque-preview.stapelberg.ch/go.dev/blog/protobuf-opaque) coming in the new protobuf 2024 edition (should be released early 2025.) Note: It should be possible to automate some or...
We can use the `cue` command line tool to generate a cue schema based on a protobuf file. This is explained [here](https://cuelang.org/docs/concept/how-cue-works-with-protocol-buffers/). It requires a small hack to get it...
The following parsing code was written for use in tests, but a better solution was found for the test case. It is also not needed for Cue-based configurations, since the...
Currently, the `test.Name` helper function will not print entries with the zero value, including for bool=false, int=0, and empty strings etc. However, it is sometimes desirable to print the subtest...
The `NewViewDuration` expects `float64` for two of its timeout inputs: ```go viewDuration = synchronizer.NewViewDuration( uint64(opts.GetTimeoutSamples()), float64(opts.GetInitialTimeout().AsDuration().Nanoseconds())/float64(time.Millisecond), float64(opts.GetMaxTimeout().AsDuration().Nanoseconds())/float64(time.Millisecond), float64(opts.GetTimeoutMultiplier()), ) ``` We should write a test for the `ViewDuration` implementation and...