GoogleCloudPlatform
Remove validation on logging_config::enable_components.
The validation does not bring too much value. Many validation logic happens when the backend process the cluster create/patch API such that a valid enum would still be rejected at the backend. OTOH, this validation logic adds complexity in supporting new enum (log types).
This also aligns with monitoring_config::enable_components, which no longer has validation.
Release Note Template for Downstream PRs (will be copied)
container: remove validation on logging_config::enable_components to allow other log types in the future
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 1 file changed, 1 insertion(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 2 deletions(-))
Tests analytics
Total tests: 200 Passed tests: 190 Skipped tests: 10 Affected tests: 0
Click here to see the affected service packages
- container
$\textcolor{green}{\textsf{All tests passed!}}$
View the build log
@yungdarek122 is there an open issue about this or a specific plan to update the allowed values here? Otherwise it would be preferable to leave the validation in place, since it does move the error earlier.
@yungdarek122, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.
If no action is taken, this PR will be closed in 28 days.
This notification can be disabled with the disable-automatic-closure label.
@yungdarek122, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.
If no action is taken, this PR will be closed in 14 days.
This notification can be disabled with the disable-automatic-closure label.
@yungdarek122, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.
If no action is taken, this PR will be closed in 2 weekdays.
This notification can be disabled with the disable-automatic-closure label.