Spanner MR CMEK Integration

[panerorenn9541]

Promote Spanner MR CMEK support to GA:

Adds the new field kmsKeyNames to encryptionConfig to support creating a Spanner MR CMEK database.

Release Note Template for Downstream PRs (will be copied)

spanner: added `kmsKeyNames` to encryptionConfig of Database

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 38 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 3 files changed, 173 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 38 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 3 files changed, 173 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Tests analytics

Total tests: 30 Passed tests: 18 Skipped tests: 12 Affected tests: 0

Click here to see the affected service packages

• spanner

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccSpannerDatabase_mrcmek $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[modular-magician]

Tests analytics

Total tests: 30 Passed tests: 18 Skipped tests: 12 Affected tests: 0

Click here to see the affected service packages

• spanner

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccSpannerDatabase_mrcmek $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[panerorenn9541]

can you update the release note based on https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/

I'll run the test in our environment to make sure its passing

Added a note.

[panerorenn9541]

I am seeing the error "The Cloud Spanner multi-region CMEK feature is currently not supported"

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 38 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 3 files changed, 173 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 38 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 3 files changed, 173 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Tests analytics

Total tests: 30 Passed tests: 18 Skipped tests: 12 Affected tests: 0

Click here to see the affected service packages

• spanner

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccSpannerDatabase_mrcmek $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[modular-magician]

Tests analytics

Total tests: 30 Passed tests: 18 Skipped tests: 12 Affected tests: 0

Click here to see the affected service packages

• spanner

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccSpannerDatabase_mrcmek $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[github-actions[bot]]

@panerorenn9541, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

[panerorenn9541]

Waiting for GA

[c2thorn]

disabled the reminders. @panerorenn9541 please ping me internally when this is good to go again

[c2thorn]

Hi @panerorenn9541

Tomorrow, the Magic Modules repository is scheduled to undergo a language migration from Ruby to Go. You can view more details about this in our announcement here: https://github.com/hashicorp/terraform-provider-google/issues/19583 (or go/mm-migration-announcement since you are a Googler)

This open pull request may become incompatible due to most YAML and .erb files converting to Go-compatible files.

Our team (Magic Modules repository maintainers) has tooling to automatically convert changes to the new language, and we can prepare a new commit for this pull request that is compatible with the migration.

In order to push the new changes to your pull request, we would need to force push the commit to your fork's branch. Our tooling saves a backup branch before converting, so we could rollback or open a new pull request if needed. We would also work with you in the event additional changes are needed.

You also have the option to update the pull request yourself after the migration. You can view a preview branch and updated documentation related to the migration changes.

We will take no action until we have your explicit permission to push changes to your fork's branch used for this pull request. Let me know if you have any further questions!

[panerorenn9541]

The Magic Modules repository maintainers have our explicit permission to push changes to your fork's branch used for this pull request.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 77 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 212 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 219 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Tests analytics

Total tests: 4146 Passed tests: 3724 Skipped tests: 417 Affected tests: 5

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccSpannerDatabase_mrcmek

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
• TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
• TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
• TestAccDataformRepository_updated
• TestAccDataprocCluster_withAutoscalingPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log] TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log] TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log] TestAccDataformRepository_updated[Error message] [Debug log] TestAccDataprocCluster_withAutoscalingPolicy[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 4146 Passed tests: 3723 Skipped tests: 417 Affected tests: 6

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccSpannerDatabase_mrcmek

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
• TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
• TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
• TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
• TestAccDataformRepository_updated
• TestAccDataprocCluster_withAutoscalingPolicy

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode: TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode: TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log] TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log] TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log] TestAccDataformRepository_updated[Error message] [Debug log] TestAccDataprocCluster_withAutoscalingPolicy[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[melinath]

@panerorenn9541 Just want to confirm this is no longer waiting for GA?

[panerorenn9541]

Yes correct, this is no longer waiting for GA.

[melinath]

~@ScottSuarez could you do a manual run of TestAccSpannerDatabase_mrcmek? It's skipped in VCR~ Never mind, we should fix the bootstrapping / IAM first.

[melinath]

Just to clarify why I'm here: Scott had asked me to take a look because he ended up making fairly significant changes to the code when porting it to Go & didn't want to be reviewing his own code. I'm not exactly sure which parts come from which of you; I've tried to call out the parts that I think Scott would be able to help, and I'd expect @panerorenn9541 to resolve the rest (but please ask if you have any questions or if anything is unclear!)

This LGTM apart from the comments I left. I'll turn the review back over to @ScottSuarez from here; let me know if you need me for anything else!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 219 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 219 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 219 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 219 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))