magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add Resource v1 SCC Findings Export to BQ Folder Config

Open vijaykanthm opened this issue 1 year ago • 4 comments

Related to http://b/356159589.

Bug Description: https://github.com/hashicorp/terraform-provider-google/issues/18848

Adding new template for V1 SCC Findings Exports to Big Query Folder Config https://cloud.google.com/security-command-center/docs/reference/rest/v1/folders.bigQueryExports

Release Note Template for Downstream PRs (will be copied)

`google_scc_folder_scc_big_query_exports`

vijaykanthm avatar Aug 29 '24 22:08 vijaykanthm

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Aug 29 '24 22:08 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 920 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 920 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Aug 29 '24 23:08 modular-magician

Tests analytics

Total tests: 15 Passed tests: 14 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • securitycenter

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterFolderBigQueryExportConfig_basic

Get to know how VCR tests work

modular-magician avatar Aug 29 '24 23:08 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccSecurityCenterFolderBigQueryExportConfig_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

modular-magician avatar Aug 29 '24 23:08 modular-magician

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Sep 03 '24 09:09 github-actions[bot]

@GoogleCloudPlatform/terraform-team @melinath This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Sep 05 '24 09:09 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 920 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 920 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Sep 09 '24 19:09 modular-magician

Tests analytics

Total tests: 15 Passed tests: 15 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • securitycenter

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

modular-magician avatar Sep 09 '24 19:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1052 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 6 files changed, 1052 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Sep 09 '24 20:09 modular-magician

Tests analytics

Total tests: 16 Passed tests: 14 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages
  • securitycenter

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterFolderBigQueryExportConfig_basic
  • TestAccSecurityCenterFolderSccBigQueryExport_sccFolderBigQueryExportConfigBasicExample

Get to know how VCR tests work

modular-magician avatar Sep 09 '24 20:09 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccSecurityCenterFolderBigQueryExportConfig_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccSecurityCenterFolderSccBigQueryExport_sccFolderBigQueryExportConfigBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician avatar Sep 09 '24 20:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1052 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 6 files changed, 1052 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Sep 09 '24 21:09 modular-magician

Tests analytics

Total tests: 16 Passed tests: 15 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • securitycenter

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterFolderSccBigQueryExport_sccFolderBigQueryExportConfigBasicExample

Get to know how VCR tests work

modular-magician avatar Sep 09 '24 21:09 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccSecurityCenterFolderSccBigQueryExport_sccFolderBigQueryExportConfigBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician avatar Sep 09 '24 21:09 modular-magician

/gcbrun

melinath avatar Sep 10 '24 23:09 melinath

/gcbrun

melinath avatar Sep 11 '24 21:09 melinath

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1052 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 6 files changed, 1052 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Sep 11 '24 22:09 modular-magician

Tests analytics

Total tests: 16 Passed tests: 15 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • securitycenter

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterFolderSccBigQueryExport_sccFolderBigQueryExportConfigBasicExample

Get to know how VCR tests work

modular-magician avatar Sep 11 '24 22:09 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccSecurityCenterFolderSccBigQueryExport_sccFolderBigQueryExportConfigBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician avatar Sep 11 '24 22:09 modular-magician

Also clarified the change request on https://github.com/GoogleCloudPlatform/magic-modules/pull/11587#discussion_r1755737188

melinath avatar Sep 11 '24 22:09 melinath

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 926 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 926 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Sep 12 '24 22:09 modular-magician

Tests analytics

Total tests: 17 Passed tests: 16 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • securitycenter

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterFolderBigQueryExportConfig_update

Get to know how VCR tests work

modular-magician avatar Sep 12 '24 22:09 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccSecurityCenterFolderBigQueryExportConfig_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

modular-magician avatar Sep 12 '24 22:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 926 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 926 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Sep 12 '24 22:09 modular-magician

Tests analytics

Total tests: 17 Passed tests: 17 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • securitycenter

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

modular-magician avatar Sep 12 '24 22:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 926 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 926 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Sep 13 '24 21:09 modular-magician

Tests analytics

Total tests: 17 Passed tests: 17 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • securitycenter

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

modular-magician avatar Sep 13 '24 21:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 926 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 926 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Sep 13 '24 21:09 modular-magician

Tests analytics

Total tests: 17 Passed tests: 16 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • securitycenter

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterFolderBigQueryExportConfig_update

Get to know how VCR tests work

modular-magician avatar Sep 13 '24 21:09 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccSecurityCenterFolderBigQueryExportConfig_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

modular-magician avatar Sep 13 '24 22:09 modular-magician