umbra-protocol
umbra-protocol copied to clipboard
On send page, show balance of each token in the dropdown
Each row in this dropdown should should the user's balance of that token
@apbendi @garyghayrat Do we definitely still want this feature?
Reasons we may not:
- we already have the max send feature, and it is pretty similar to this in intent
- no one has asked for this feature (I'm told)
- this might take a bit more time than it's worth
- there are some tricky race conditions that we need to work around to make balance loading work properly, especially when switching chains
- it's going to need some design work -- we'll probably want to modify the
base-selectcomponent with a new slot to display the balances beneath the main select text
Yea david and I chatted earlier, IMO we should close this issue and focus on #378 instead due to some trickiness above that doesn't seem worthwhile
In case we do decide to move forward with this issue, this is where I left off.
FWIW, n=1, as I'm working on other send-page tickets, I kind of miss this feature now 😅
I actually still think this feature would be nice but it's not worth if it's tricky and a lot of work, as it sounds it is. So I'd say leave it open but just move it to the Backlog category instead of To Do
@davidlaprade Do you remember what the trickiness here was? It sounds like this should be simple because we already have the balances in the wallet store, and I can't remember the details of why this isn't simple
I think all I can remember is what's in this comment: https://github.com/ScopeLift/umbra-protocol/issues/294#issuecomment-1225946597