umbra-protocol icon indicating copy to clipboard operation
umbra-protocol copied to clipboard

On send page, show balance of each token in the dropdown

Open mds1 opened this issue 3 years ago • 5 comments

Each row in this dropdown should should the user's balance of that token

image

mds1 avatar Feb 17 '22 14:02 mds1

@apbendi @garyghayrat Do we definitely still want this feature?

Reasons we may not:

  • we already have the max send feature, and it is pretty similar to this in intent
  • no one has asked for this feature (I'm told)
  • this might take a bit more time than it's worth
    • there are some tricky race conditions that we need to work around to make balance loading work properly, especially when switching chains
    • it's going to need some design work -- we'll probably want to modify the base-select component with a new slot to display the balances beneath the main select text

davidlaprade avatar Aug 24 '22 16:08 davidlaprade

Yea david and I chatted earlier, IMO we should close this issue and focus on #378 instead due to some trickiness above that doesn't seem worthwhile

mds1 avatar Aug 24 '22 16:08 mds1

In case we do decide to move forward with this issue, this is where I left off.

davidlaprade avatar Aug 24 '22 17:08 davidlaprade

FWIW, n=1, as I'm working on other send-page tickets, I kind of miss this feature now 😅

davidlaprade avatar Aug 25 '22 14:08 davidlaprade

I actually still think this feature would be nice but it's not worth if it's tricky and a lot of work, as it sounds it is. So I'd say leave it open but just move it to the Backlog category instead of To Do

apbendi avatar Aug 25 '22 15:08 apbendi

@davidlaprade Do you remember what the trickiness here was? It sounds like this should be simple because we already have the balances in the wallet store, and I can't remember the details of why this isn't simple

mds1 avatar Feb 06 '23 17:02 mds1

I think all I can remember is what's in this comment: https://github.com/ScopeLift/umbra-protocol/issues/294#issuecomment-1225946597

davidlaprade avatar Feb 06 '23 20:02 davidlaprade