Matt Solomon

Results 519 comments of Matt Solomon

A PR for this would be awesome! Definitely down to support more frameworks, and it would be cool to support huff as I don't think it's supported anywhere else. I'm...

> Split up `frameworks.rs` into a `frameworks` folder so each framework can live in it's own file, e.g. `foundry.rs`. This is a good initial PR. Just completed this one in...

Sounds great, looking forward to it!

I'd suggest requiring the config to just live in `foundry.toml` to avoid needing new config files for each tool. See https://github.com/foundry-rs/foundry/issues/5866 for my suggestion on how this would look

Amazing! Testing it out now and have two comments. Given: ``` MyContract._efficientHash.sol ├── It should never revert. └── It should match the output of a high-level hash. ``` Then run...

> Even though this is inconsistent with how actions behave when they have parent conditions, I think it is less surprising, since actions without conditions suggest unrelated function invariants. That...

> Sorry for the long post, I just want to get this right. No worries at all, this is a valuable discussion and I appreciate it! --- > Let's take...

Hmm @PaulRBerg @alexfertel what do you think about the current repetitiveness? For example: ```solidity function test_WhenFirstArgIsSmallerThanSecondArg() external whenFirstArgIsSmallerThanSecondArg { // It should match the result of `keccak256(abi.encodePacked(a,b))`. } ``` We...

Ah thanks, will check out that discussion!

forge's `--skip` does accept globs, and `--skip test` and `--skip script` are just aliases for `*.t.sol` and `*.s.sol` respectively (i.e. they don't actually skip the test and script folders, just...