Michael Baudis
Michael Baudis
+1 / interested
I am for solving this through an OntologyTerm object, as part of a general BioFeatures collection object which contains information private to the BioSample. Others would be histology, anatomic location,...
There seems to be consent among the MTT to - rename the `diagnosis` attribute in `BioSample` to something more neutral, a.k.a. `SampleCharacteristics`, `SampleFeatures`, `SampleOntologies`... - change the value to be...
@david4096 Please have a look at https://github.com/ga4gh/schemas/pull/710 (sorry for the committ mess...).
Thanks @david4096. Other comments/votes, please; @mcourtot, @mdmiller53, @sarahhunt ...?
@mdmiller53 Thanks; and regarding the qualifiers, the point is certainly well taken. But options are either in the OT, or in the wrapper object. The structure there is not immediately...
So pls. vote/comment on https://github.com/ga4gh/schemas/issues/711 now.
@mdmiller53 I'll close this. https://github.com/ga4gh/schemas/pull/725 (which was merged into metadata-integration branch) defines this as being covered through better definition of OntologyTerms (termId + termLabel, and URI provided through a service),...
@david4096 My take here: * a biosample will have only one value for the site; however * `tissue_site` is overly verbose; consider e.g. environmental samples, metagenomic (i.e. from some anatomical...
@david4096 @mcourtot Yes, and in fact in arrayMap we use "SAMPLESOURCE" for similar purposes (cell line, metastasis::liver ...). So if somebody wants to craft a PR for this ...