Maxime U Garcia
Maxime U Garcia
We're missing CHANGELOG + tests + subway map
@nf-core-bot fix linting pretty please :pray:
Can you add this in sarek/tests/config/pytesttags.yml after the `concatenate_vcfs` trigger? ``` normalize_vcfs: - conf/modules/post_variant_calling.config - modules/nf-core/bcftools/concat/** - modules/nf-core/bcftools/mpileup/** - modules/nf-core/bcftools/norm/** - modules/nf-core/bcftools/sort/** - modules/nf-core/deepvariant/** - modules/nf-core/freebayes/** - modules/nf-core/gatk4/haplotypecaller/** - modules/nf-core/gatk4/mergevcfs/**...
issues we still need to assess: WHY do we output vcfs_tbi from the concatenate subworkflow, when we just need vcf for vcftools and we don't seem to remove them anywhere?...
@Patricie34 sorry, I forgot to merge in https://github.com/nf-core/sarek/pull/1760 (which is now done). Can you sync you branch once more, and move your PR up in the CHANGELOG?
We'll be merging in `dev_normalization`so we can easilly test logic and figure out everything before finally merging in in `dev`
I like where this is going. Thanks a lot @vaxyzek. Let's leave this as Draft until https://github.com/nf-core/modules/pull/6622 is merged.
minor issues with managing merge conflicts, I made suggestions