Maximilian Linhoff

Results 344 comments of Maximilian Linhoff

I'll open a PR with unit test cases and then we can decide about the wanted behaviour for each of them

This needs to be addressed. Software is developed by large teams with fluctuating members. In the most extreme case, people die or become otherwise completely unreachable. Having to create a...

@adonath yes, exactly, this is the `FOV_ALIGN=ALTAZ` frame, a second frame could be made by changing the required frame of the origin coordinate.

Starting the evaluation of what is required by gammapy and how that would be best represented in memory and where that information is currently read from ### Observation The current...

### EventList EventList currently directly contains the table as read using `Table.read` from the input file. This should be separated. We could still use a table or define array-like attributes...

### IRFs We need * is_pointlike for everything but the PSF (Background is arguable, you could provide point-like background estimates, but this is uncommon I think) * fov_alignment for IRFs...

@adonath Indeed, but that goes again through fixed_pointing_info, not using the location property on the observation.

Here is a shot related to #3797 at how this would look like, here using a dataclass,: ```python from typing import Union from astropy.time import Time from astropy.io.fits import Header...

Still missing is converting the time-like columns of things to be actual `Time` columns and creating / reversing the conversion to reference + delta on reading / writing