Maximilian Linhoff

Results 344 comments of Maximilian Linhoff

Why is it not possible? Wouldn't this work? ``` obs.events.table["PHASE"] = phase obs.write("...) ``` ?

> obs.fixed_pointing_info.meta is lost in obs_new This is strange, since this should come from the info in the events header table.

> If you explicitly try to set obs.events = events_new it raises AttributeError: can't set attribute. What you propose silently fails I know. But my code does not change `events`...

@AtreyeeS `Observation.read` does not use the lazy loading mechanism, it just actually reads the observation into memory.

One point regarding pulsar phase: DL3 files are source agnotic and phase is a property of an assumed source. There could even be the case where you have two pulsars...

Is there already a decision how to handle deprecations? E.g. we could add a `binsize` argument now that supports units and add the unit support, keeping the unitless `binsz` but...

> This part of Gammapy probably won't change, times have to be given in the FITS standard format. Why? Why not just use an astropy.time.Time? Why force an on disk...

> I agree with @maxnoe that at no point we should use a "crawler" to automatically get information from people from the GitHub profiles. However we will of course use...

One last general note: this document only mentions "Stored on GIthub, Github contributions, tracked using GitHub ...". I think it is important to distinguish things that are stored in the...

This is a huge and general problem for new users. Gammapy errors in general are very unhelpful and usually come from deep in the hierarchy from classes, usually something like...