Maximilian Linhoff

Results 344 comments of Maximilian Linhoff

> But I would saying having wheels on PyPI and distributions on conda-forge (which you already have) would be a big win. [cibuildwheel](https://cibuildwheel.pypa.io/) is your friend here for dealing with...

Li&Ma does not hold if the counts are correlated, which is the case if the regions overlap. We should either prohibit this case or not provide a significance for distances...

Also, I think you've re-implemented the `WobbleRegionsFinder` here, you could just use it: https://docs.gammapy.org/2.0/api/gammapy.makers.WobbleRegionsFinder.html#gammapy.makers.WobbleRegionsFinder

Just ran into the same issue with the current version (`25.04.2.2.1`)

@registerrier Time is the other big issue in gammapy where things we heavily on how things are stored in fits, with implicit assumptions etc. We should instead use `Time` columns...

You also need to look at the db model definition. The upgrade/migrate tests should also detect a _missing_ migration script due to a schema change in the model definition.

> and just allow extension via kwargs I don't think it makes sense to have arbitrary kwargs in `extract_scope`, because `extract_scope` is called all over the place server-side in rucio,...

CC @fstagni for the DIRAC config

> I also see you wrote a configure.py which is a stripped-down version of the dirac-configure command, I am not sure it's the best way to proceed, but as you...

@bari12 I had two questions in the top post, maybe you have an idea what to do?