Maximilian Linhoff

Results 344 comments of Maximilian Linhoff

This would be really helpful for us moving from `numpy.polyfit` to the options recommended by the docs. What's the status here?

Ok, I removed that case for now. The rest of the cases is now passing.

@pfmoore you can support an editable install in a project using PEP 517 by adding a rather minimal setup.py. But then, it is impossible to have `-e` and `--user`

I suspect that this is due to the deprecation of the non-si units, but that should not affect reading and parsing!

More context: The current FITS standard says this about units: >The units of all FITS header keyword values, with the exception of measurements of angles, > should conform with the...

Even the > should conform with the recommendations in the IAU Style Manual is unclear, as at least to me it's not clear how defined but deprecated units should be...

That wouldn't solve the case where the value is read from a float32 into a float64, which can happen pretty fast due to the places where casting can happen. Better...

This is what I did to fix it on our end: https://github.com/cta-observatory/ctapipe/pull/2077/files#diff-d2022785b8c35b2f43d3b9d43c3721efaa9339d98dbff39c864172f1ba2f4f6f ```python _half_pi = 0.5 * np.pi _half_pi_maxval = (1 + 1e-6) * _half_pi def _clip_altitude_if_close(altitude): """ Round absolute...

No, the point is that this casts to float64.