Max Katz

Results 288 comments of Max Katz

We now have Control.Theme property on each control. So, we need some other naming options: - `Control.ThemeVariant` (of `ThemeVariant` type) - after previous discussion this one was prefered - `Control.ThemeMode`...

so far: master: | Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | |------------------------- |-------------:|-----------:|-----------:|---------:|---------:|--------:|----------:| | CreateCalendar | 15,253.55 us...

@DrWenz sorry to bother you, but I wonder how this PR affects startup time on your low end devices. From my testing with control catalog and dotTrace on my machine...

@DrWenz master. As we already know that master (and likely this PR) is faster than 0.18.0. @timunie yes, I did rerun some of the benchmarks

@DrWenz instead of FluentThemeMode there is an Application.ThemeVariant now. Which also can be set on each window independently. While having single resource dictionary for all of these variants. If you...

To consider https://github.com/microsoft/WindowsAppSDK/issues/41 https://github.com/dotnet/winforms/issues/5166

I can reproduce https://github.com/AvaloniaUI/Avalonia/issues/8070#issuecomment-1116277384 issue on ControlCatalog CalendarDatePicker page: ![image](https://user-images.githubusercontent.com/3163374/169205031-b5c0a55f-eed1-4cf2-9b99-f368817240be.png) 1. 125% scaling 2. Vertically centered textbox 3. Empty text presenter 4. Current master

@Slupy it's not possible to help without being able to reproduce it. Do you have anything that might help?

> I'm seeing both Avalonia.Skia and Avalonia.Vulkan having public API members exposing raw Silk.NET types. I understand that replacing Silk.NET for Avalonia.Vulkan might be problematic, and I won't be strictly...

Doesn't sounds like a bug for me. Isn't WPF/UWP has the same behavior? Resources is a dictionary instance per control, and to lookup parent control it has separated method.