Maurelian

Results 73 comments of Maurelian

Trying the old pull and push to get [these tests working](https://app.circleci.com/pipelines/github/ethereum-optimism/optimism?branch=contracts_bedrock%2Fhardhat_tasks). 🤞

> How did ds-test get installed before? Is ds-test present and just not found, or not at all installed? It's also (and was previously) installed using `yarn` as well ([see...

I looked in to using a `postinstall` script https://github.com/maurelian/forge-std/blob/6bb1e59a05a8170cd9c80f302f65dc8228224b6e/package.json?rgh-link-date=2022-11-03T23%3A40%3A52Z#L17 But that is apparently [very buggy](https://github.com/yarnpkg/yarn/issues/5476) in `yarn`.

Yep, that commit (5bafa16b4a6aa67c503d96294be846a22a6f6efb) works thanks! Should we use that commit, or the current tip of master (on which CI seems to be failing)?

Thanks for this thoughtful response and taking the time to look into the code! For context, this issue was requested by @smartcontracts in his review of the [initial PR](https://github.com/ethereum-optimism/optimism/pull/1722/files#r745894985). So...

Good catch. I think this bug is a good argument for the changed proposed in #3064. This lgtm, but please see my message in slack about a proposal for how...

Can we move this [here](https://github.com/ethereum-optimism/optimism-audit-fixes) so that it can get reviewed along with audit fixes?

I moved your commit to [here](https://github.com/ethereum-optimism/optimism-audit-fixes/pull/2), so I think we can close this for now.