optimism icon indicating copy to clipboard operation
optimism copied to clipboard

Contracts-bedrock: put hardhat tasks in /tasks folder

Open cyborgdennett opened this issue 3 years ago • 2 comments

Description

I moved tasks from hardhat.config.ts to their own files in /tasks

Thanks to @smartcontracts for increasing my commit score 💯 #3777

cyborgdennett avatar Oct 26 '22 11:10 cyborgdennett

⚠️ No Changeset found

Latest commit: 04de3793f82030dc9e5d45da51f145fd28165467

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 26 '22 11:10 changeset-bot[bot]

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

mergify[bot] avatar Oct 26 '22 11:10 mergify[bot]

Trying the old pull and push to get these tests working. 🤞

maurelian avatar Oct 27 '22 16:10 maurelian

This PR has been added to the merge queue, and will be merged soon.

mergify[bot] avatar Oct 27 '22 16:10 mergify[bot]

This PR is next in line to be merged, and will be merged as soon as checks pass.

mergify[bot] avatar Oct 27 '22 16:10 mergify[bot]

I'm pulling this from the merge train. @mslipper op-*-publish-dev are dependencies for hive-test-* & the hive tests are required but the publish ones are not. We should probably make the publish ones required or somehow fail the hive tests fast.

trianglesphere avatar Oct 27 '22 18:10 trianglesphere

Bump @trianglesphere on progress here

tynes avatar Oct 31 '22 19:10 tynes

Bump @trianglesphere on progress here

@mslipper did you check on this? If merges/rebases aren't fixing the publish step, do we need to ignore the check? It feels like there might be a permission issue with publishing / authenticating here.

trianglesphere avatar Oct 31 '22 19:10 trianglesphere