contracts-bedrock: fix `OptimismMintableERC20Created`

[tynes]

Description

The names of the event args were backwards from what they were supposed to be. I noticed this while writing integration tests for the sdk.

The event is used like this:

emit OptimismMintableERC20Created(_remoteToken, address(localToken), msg.sender);

The event was updated to look like this:

event OptimismMintableERC20Created(
    address indexed remoteToken,
    address indexed localToken,
    address deployer
);

The remoteToken is first and the localToken is second.

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 761f90f33f9bdd5ff4f1c8c0f6d328ee12e260bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@eth-optimism/contracts-bedrock	Patch
@eth-optimism/actor-tests	Patch
@eth-optimism/sdk	Patch
@eth-optimism/drippie-mon	Patch
@eth-optimism/message-relayer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[maurelian]

Good catch. I think this bug is a good argument for the changed proposed in #3064.

This lgtm, but please see my message in slack about a proposal for how to handle all impl changes during the OZ audit.

[maurelian]

Can we move this here so that it can get reviewed along with audit fixes?

[maurelian]

I moved your commit to here, so I think we can close this for now.

[github-actions[bot]]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[maurelian]

@tynes I think this got stale because it was moved into the fixes repo temporarily. I'm reopening it now, and will push a rebase shortly.

[mergify[bot]]

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

[maurelian]

Need to do a bit of debugging to figure out why this broke the deposit-erc20 integration test

[mergify[bot]]

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

[tynes]

See this comment for fixing the tests: https://github.com/ethereum-optimism/optimism/blob/4a5e1832686f1375be3fb1b20768a67625455d68/packages/sdk/tasks/deposit-erc20.ts#L78-L80

[mergify[bot]]

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

[mergify[bot]]

This PR has been added to the merge queue, and will be merged soon.

[mergify[bot]]

This PR is next in line to be merged, and will be merged as soon as checks pass.