Matt Pavlovich

Results 197 comments of Matt Pavlovich

@shikhar97gupta these changes are looking good! One final request -- move the 'with destination name' to a separate method. This will ensure that users that use the existing method do...

@shikhar97gupta looks good! If you can get the last housekeeping tasks done, we'll include this change in the next set of 5.17.x, 5.18.x and 6.1.x releases. - [ ] Rebase...

How does the error occur when the adapters are added via directory listing? There should not be duplication.

@asanguinetti thank you for the contribution, we'll look into it. Have you had a chance to test this change with the other transport (non-TCP/NIO) connectors (like stomp, mqtt.. etc)?

JIRA created: [AMQ-9392](https://issues.apache.org/jira/browse/AMQ-9392)

> Great to see work done on this! 👍 > > What about other threads like `ActiveMQ Data File Writer`, `ActiveMQ Journal *`, can/should these be virtual too or is...

One reason I thought iterating over the index was preferred vs seeking over the index was to skip over and not include any messages in the ackedAndPrepared collection. ``` if...

How about something along the lines of a RandomAccessFileFactory? 1. start() / stop() methods to handle the state of the ring buffers and if a dedicated thread is needed 2....