Matt Pavlovich

@gemmellr yep, saw that. Def related to your points above. I’m cleaning that up first thing this morning. UPDATE: Change is in for deliveryTime http unit tests passed locally (including...

Grrr.. fighting with one test that passes-locally-fails-on-apache-ci. The test totally looks like it could be something that was impacted by the changes in the PR, but the exception stack doesn't...

> @mattrpav it seems related to security enforcement we added. But it should fail on your machine as well. I agree with you =) The connection factory is setup without...

@gemmellr yep. in my update to the test, I explicitly set the trusted packages list to a new list and get rid of using the system property (which may have...

That amqp test fix worked. I'm going to break it out into a separate PR for consideration into 5.17.0

@gemmellr @tabish121 @cshannon @jbonofre I have gone through all the requests in previous review rounds and believe I have addressed all open items. Please review the latest. Thank you

> I'll admit I gave up before the end as many of the comments seem to apply to a lot of the tests and I got bored seeing/saying the same...

Unit test execution times: Local MacBook Pro (total 32.535s): ``` [INFO] Running org.apache.activemq.jms2.ActiveMQJMS2AckModesTest [INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.601 s - in org.apache.activemq.jms2.ActiveMQJMS2AckModesTest...

Total test time down < 13s on local MacBook Pro ``` [INFO] Running org.apache.activemq.jms2.ActiveMQJMS2AckModesTest [INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.333 s - in...

Full unit test suite passing ref: https://ci-builds.apache.org/blue/organizations/jenkins/ActiveMQ%2FActiveMQ/detail/PR-729/33/pipeline JMS 2.0 tests < 17s on Apache Jenkins ``` [INFO] Running org.apache.activemq.jms2.ActiveMQJMS2AckModesTest [INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time...