Added destination field to Job

[shikhar97gupta]

JIRA issue: https://issues.apache.org/jira/projects/AMQ/issues/AMQ-9166?filter=allopenissues&orderby=created+DESC%2C+priority+DESC%2C+updated+DESC

[mattrpav]

Hi @shikhar97gupta -- I'll start reviewing the PR this weekend.

Please review: https://community.apache.org/newcomers/index.html

[shikhar97gupta]

How to resolve these check errors?

I am unable to replicate error on running the tests with the same command as in the checks tab (mvn -B -e -fae test).

The activemq code clone on my system gives a different error (fails a broker test) on running the same command compared to the error mentioned in the 'Log Tail' of error checks tab.

[shikhar97gupta]

@mattrpav Are these changes fine? Also, I think I have pushed commits in a bad way in this PR while trying squash multiple commits.....should I create a new PR?

[mattrpav]

@shikhar97gupta these changes are looking good! One final request -- move the 'with destination name' to a separate method. This will ensure that users that use the existing method do not have any performance impact when viewing scheduled jobs.

Example:

// Existing method
public TabularData getAllJobs(String startTime, String finishTime) throws Exception {
   return getAllJobs(startTime, finishTime, false);
}

// New method
public TabularData getAllJobs(String startTime, String finishTime, boolean includeDestinationName) throws Exception {
   ...
//    do the work here  
   ...
}

[shikhar97gupta]

@shikhar97gupta these changes are looking good! One final request -- move the 'with destination name' to a separate method. This will ensure that users that use the existing method do not have any performance impact when viewing scheduled jobs.

@mattrpav Applied this change for all 3 methods separately -- getAllJobs(), getAllJobs(String, String) and getNextScheduleJobs()

[mattrpav]

@shikhar97gupta looks good! If you can get the last housekeeping tasks done, we'll include this change in the next set of 5.17.x, 5.18.x and 6.1.x releases.

• [ ] Rebase your PR off of 'main'
• [ ] Add a unit test to validate the destination name field is working correctly in this test:

activemq-unit-tests/src/test/java/org/apache/activemq/broker/scheduler/JobSchedulerJmxManagementTests.java