Matt Mayer

Results 215 comments of Matt Mayer

You can take a look at https://dev.to/matthewmayer/leveling-up-your-custom-fake-data-with-fakerjs-3f7m for strategies on how to provide your own data when Faker doesn't have it built in.

If you do create some useful arrays of data feel free to contribute them back here. That would definitely increase the chance of this getting implemented! Typically we would have...

For medicines there might be logic in using completely fictitious medicine brandnames so there's no confusing them with real medicines.

I'm just thinking if you had like a mockup of a fake prescription then it's probably not a good idea to have real medicines in there. Like if you show...

I mean the project is called "Faker" 🤣 we generally try to create plausible looking, not real data. But I get your point. Latin-sounding names can be easily made already...

I think a more realistic algorithm for prices might be: * Generate the raw price * Round to 2 or 3 significant digits (e.g. 1.23 or 12.30 or 123.00 or...

> We might need more tests for the new behavior: > > ```ts > faker.seed(4); > faker.commerce.price({ dec: 2, min: 1, max: 1.1 }); // 1.15 ⚠️ > ``` To...

I'm still in favour of overriding the last two digits per my earlier review for more realistic prices.

While it's not strictly a breaking change I think it's worth a mention in the migration guide given that it changes the behavior of the method.

Yes these should be removed (we did this for English in https://github.com/faker-js/faker/discussions/1631 ) Would you be able to make a PR for removing any offensive vocabulary in hu locale?