faker icon indicating copy to clipboard operation
faker copied to clipboard

Pejorative Expression

Open dev-el-op opened this issue 1 year ago • 6 comments

I found a pejorative expression among the Hungarian adopted words. In line 8173 of the /src/locales/hu/word/noun.ts file, the word means btch in Hungarian. One of our testers noticed it when in a literal translation the web address of one of the example sales locations became https://unbred-btch.com/ in Hungarian.

dev-el-op avatar Dec 11 '23 15:12 dev-el-op

Okey, now i found like 15 of them in the same file 😅

dev-el-op avatar Dec 11 '23 15:12 dev-el-op

Yes these should be removed (we did this for English in https://github.com/faker-js/faker/discussions/1631 )

Would you be able to make a PR for removing any offensive vocabulary in hu locale?

matthewmayer avatar Dec 11 '23 16:12 matthewmayer

Absolutely, I can take care of removing any offensive vocabulary in the Hungarian locale. I'll aim to submit a pull request for this task within this week.

dev-el-op avatar Dec 11 '23 16:12 dev-el-op

I also noticed, that the file is huge with 10620 lines. We should reduce that to 1000 entries (not sure though whether it should be in a separate PR for the pejorative expression removal).

ST-DDT avatar Dec 11 '23 18:12 ST-DDT

I also noticed, that the file is huge with 10620 lines. We should reduce that to 1000 entries (not sure though whether it should be in a separate PR for the pejorative expression removal).

I think separating the PRs would be better--- remove the pejorative expressions first, then reduce to 1000 entries.

import-brain avatar Dec 13 '23 05:12 import-brain

Might be better to reduce to 1000 first, then less hunting is required for the pejorative expressions!

matthewmayer avatar Dec 13 '23 07:12 matthewmayer

@dev-el-op Do you have time to create a PR that removes those expressions?

ST-DDT avatar Feb 24 '24 07:02 ST-DDT

@dev-el-op Any idea when you have time for this?

ST-DDT avatar Mar 04 '24 22:03 ST-DDT

I created https://github.com/faker-js/faker/pull/2816 to hopefully remove all offending words.

  • https://github.com/faker-js/faker/pull/2816

If there are other offending words please tell me. Otherwise we have to do that in a future PR.

ST-DDT avatar Apr 13 '24 19:04 ST-DDT