Matt Mayer
Matt Mayer
I would be in favour of a different module name.
Although I think "typeof" is a reserved word so it would have to be something else.
How about faker.type.*
What if there was a new parameter like {object:true} to return the object instead of a string. Then it wouldn't be breaking.
(or a new method like `faker.location.stateObject()`) Might be worth the slightly more awkward naming to avoid breaking change on a very old & stable method.
I think https://github.com/faker-js/faker/issues/1850 should be a prerequisite for this, because i imagine there's a fair amount of existing code like `const address = faker.helpers.fake("{{location.city}}, {{location.state}}")` and there won't be an...
i'm still about dubious about changing the behavior of the existing methods. Sure, it will be in the migration guide, but people don't always read those, and subtle changes like...
even if harmless, if this affects the behavior of the bundler it should probably be considered a semver-major change.
It's waiting for 10 upvotes Where faker doesn't provide the exact data you need you can generally get a good result by just using faker.helpers.arrayElement with an array of static...
Generally sounds good to me! Note `isbn` already appears in the `faker.commerce` module. We could probably make that a deprecated alias and move the implementation here Id probably remove translator...