Matt Mayer

Results 215 comments of Matt Mayer

For example in the new food module there was a description like "400g of delicious steak" A menu might realistically have a 350g or 400g steak but not a 362g...

Would you expect it to return "German" or "Deutsch" in the `en` locale? Might need to split into two methods for that, or add a parameter to determine if you...

Something similar could also be achieved by having a variant of faker.helpers.arrayElement where each element of the array has a fixed independent probability of being included in the return values

"4/2", alternative "4 m. 2", means building 4, apartment 2 So it would make sense to remove '#/#' from building_number and add '/#', '/##' as alternative secondary_address formats? https://github.com/faker-js/faker/blob/next/src/locales/pl/location/street_address.ts would...

I'm not clear about the '##a', '##b', '##c' patterns. Are the "a", "b", "c" considered part of the secondary address (ie these are room/apartment a, b and c, or are...

Seems to be the case, for example this company is at "1A/2", so building number is 1A. https://www.emis.com/php/company-profile/PL/Rockpath_Poland_Sp_z_oo_en_4450815.html Ul. Karola Libelta 1A/2 Poznan; Wielkopolskie; Postal Code: 61-706

So 3/5/7 can also mean like a big building which has merged the buildings 3, 5 and 7? But presumably those would normally be in ascending order right? So 5/3...

If I live say say building 14/16, apartment 2, how would you write my address ?

The new implementations of these methods seem so different from the old methods that it feels confusing to keep them with the same names. I feel if someone proposed "a...

Wouldn't it make the migration path much easier if new names were used for the new methods For example faker.datatype.numberType instead of faker.datatype.number?