Matt Gallo

Results 34 comments of Matt Gallo

Looks like everything is good to go here now 🎉

Items discussed during latest design review: - [ ] Resizable columns - [ ] Reordering rows - [x] Cell header border color - [ ] Cell contents on top of...

Thank you @chloeleekjh and @janhassel for both of your feedback here. I have first gone through Jan's feedback, I was able to address most of the items. For 2 and...

Hi @chloeleekjh, I've had a chance to address some of the items you mentioned above. I have some notes that I'll leave below: 1. Updated active cell text color to...

Hi @chloeleekjh and @janhassel 👋 would you be able to review the updates here. Mitchell and I had discussed about adding multi row selection (with shift key) after the initial...

Thanks for the review @janhassel! I've fixed numbers 1 and 2 on the list. @Ratheeshrajan is working on 4-7. Number 3 is a bit more complex and looks like Carbon...

Datagrid inline editing support has been added. https://carbon-for-ibm-products.netlify.app/?path=/story/ibm-products-components-datagrid-datagrid-canary-extensions-inlineedit--inline-edit-usage-story

Yes, so typically the way we've handled components with strings/labels/etc. is by adding a string prop for each that the consumer will pass to the component. This allows our library...

Updates will be made to this PR to support some of the missing pieces @janhassel pointed out, specifically adding cell buttons when using `useInlineEdit` and arrow key support.

This is now fixed in `1.34.1`, confirmed with an app using react-scripts by running `react-scripts build` and no longer see source map errors