Matjaž Horvat

Results 288 comments of Matjaž Horvat

> That's weird. Why didn't I see the traceback in Papertrail? Is that log local? It's here: https://my.na-01.cloud.solarwinds.com/205659034034892800/logs?q=host%3A%22mozilla-pontoon%22&focus=1845046349726113796&selected=1845046349726113796

Should we just show all users with access to /admin in the Project Manager list and drop references to the `project_managers` group?

Pardon, my question was wrong. We actually already show all users with access to /admin in the Project Manager list. There's not that much overlap with the staff users (who...

The `can_manage_project` permission is required to access the /admin page. It's assigned to members of the `project_managers` group, which are shown in the Project Manager list in the Project Admin...

Hey @RafaelJohn9! Sure thing, I've just assigned the issue to you!

The problem is specific for the missing strings. It was caused by https://github.com/mozilla/pontoon/pull/3536, which removed the `AggregatedStats` abstract model, making the `missing_strings` property absent from the `InsightsSnapshot`.

@flodolo Could you please take it for a spin on stage? In addition to addressing the review comments, I've also fix the color for the MNGR status, which was broken...

Yeah, we have inconsistent definitions of user statuses between: https://github.com/mozilla/pontoon/blob/da0c8ec105289c5d31ddfc9e46ed7773438c0b05/pontoon/base/views.py#L860 (used when adding a comment) https://github.com/mozilla/pontoon/blob/da0c8ec105289c5d31ddfc9e46ed7773438c0b05/pontoon/base/models/user.py#L197 (used everywhere else)

Could you please also take a look at the code? I can't flag you for a review, since you're the author of the PR.