Matan Lurey

Results 470 comments of Matan Lurey

> Update the policy to be more explicit about the breaking change approval process. Yes, at this point I'd settle for: > You're expected not to break Flutter, but we...

I chatted with @athomas offline a bit, but the tl;dr is I don't think the Dart team or Dart infra is doing anything wrong - I'm just looking for more...

Do we see any downsides in restricting in this much? Adding a restriction that only `options` can be set is pretty easy, otherwise. /cc @jakemac53 @natebosch

At least a few times this week I saw windows builds failing, I'll admit I didn't check the logs for details - so perhaps this issue should be retitled as...

> > It is not (very recent PRs). > > @matanlurey if you share the earliest commit that will qualify, I can find you an unused branch. https://github.com/flutter/engine/pull/51739 (`8630c4b`).

Right, I need to land and then open up cherry-picks against it, etc, similar to a real release branch.

I don't mind doing those steps. It's also 4:45 and I won't do them today anyway. /cc @gaaclarke maybe we can chat for 5m tomorrow and get your take.