Matan Lurey

Results 465 comments of Matan Lurey

@XilaiZhang and I are going to pair on this together next week. Edit: @gaaclarke will take the lead on this, I have a lot on my plate :)

I'm proposing the easiest possible fix for this, https://github.com/flutter/cocoon/pull/3706.

I _thought_ `package: args` was relaxed about flag location, I need to double check. I can volunteer in either case to get the bug fixed at the tools level.

I paired with @jonahwilliams for a few minutes, and I'm out of 🧠 power to fix this today, but tl;dr there are [_multiple_ different commands that support `--machine`](https://github.com/search?q=repo%3Aflutter%2Fflutter+path%3A%2F%5Epackages%5C%2Fflutter_tools%5C%2F%2F+%2F%27machine%27%2F&type=code) today, so...

Thanks Victoria! It does seem like it's happening also for Android emulators. I'll see if I can get someone who understands the engine framework lifecycles a bit to check this...

@sigmundch What do you think of a bot-assisted technique, similar to what @mraleph did for symbolizer bot? I.e. > @fluttergithubbot allow-list-violations-of: avoid_legacy_foo

https://github.com/flutter-symbolizer-bot, perhaps we could get @mraleph to do a tech talk :)

Oh, this _might_ address https://github.com/flutter/flutter/issues/126889 @gaaclarke?