Matan Lurey

Results 465 comments of Matan Lurey

@eyebrowsoffire I'll need some help debugging why the WASM implementation hits an infinite loop. I setup a few minutes this Friday to pair if that's more helpful, thanks!

> @eyebrowsoffire I'll need some help debugging why the WASM implementation hits an infinite loop. I setup a few minutes this Friday to pair if that's more helpful, thanks! Might...

Yup that did it, all tests passing!

> Specifying the target to et also seems to be more fussy than ninja. I can specify just impeller_unittests (the executable name) directly to ninja and it seems to figure...

I can confirm this takes a lot longer than you'd expect: ```sh flutter % time et build -c host_debug_unopt_arm64 //flutter/impeller:impeller_unittests [2024-05-10T11:58:13.524][macos/host_debug_unopt_arm64: GN]: OK [2024-05-10T11:58:14.451][macos/host_debug_unopt_arm64: RBE startup]: OK [macos/host_debug_unopt_arm64: ninja] 0.0%...

FWIW, this is the same command with `-v` so we can see what executables are being run: ```sh lutter % time et build -c host_debug_unopt_arm64 //flutter/impeller:impeller_unittests -v [2024-05-10T11:59:26.743][macos/host_debug_unopt_arm64: GN]: STARTING:...

Confirming above, it takes >10s before `runBuild` is invoked, i.e. here: ![image](https://github.com/flutter/flutter/assets/168174/f9698ff5-ba04-4083-86b8-22f3111211f5)

This is the block that takes 10s: ```dart final List? selectedTargets = await targetsFromCommandLine( environment, build, argResults!.rest, enableRbe: useRbe, ); ```