build icon indicating copy to clipboard operation
build copied to clipboard

Enforce only changing certain fields in build.<config>.yaml files

Open jakemac53 opened this issue 7 years ago • 3 comments

Today it looks like we just rely on the user to keep these in sync, we should actually merge the two files and only allow you to overwrite the options fields for builders.

Otherwise in the best case you have to duplicate a lot between files, and in the worst case users end up invalidating their entire build any time they switch configurations.

jakemac53 avatar Feb 16 '18 20:02 jakemac53

Do we see any downsides in restricting in this much?

Adding a restriction that only options can be set is pretty easy, otherwise.

/cc @jakemac53 @natebosch

matanlurey avatar Feb 25 '18 00:02 matanlurey

I think the restriction makes sense, though it does point towards potentially splitting up the file #885

For now we can just be careful how this is documented and make sure we have helpful error messages.

natebosch avatar Feb 25 '18 17:02 natebosch

Do we see any downsides in restricting in this much?

Not that I know of - if we allow deeper changes then it would require full rebuilds when people change their --config option (the build structure would change).

jakemac53 avatar Feb 26 '18 16:02 jakemac53