Martin Fleischmann

Results 538 comments of Martin Fleischmann

Hi, this looks like a great addition. We would need to add individual functions computing circuity etc and then one using them all to compute SNDi. I have no capacity...

You mean like we do in `momepy.remove_false_nodes` or differently? http://docs.momepy.org/en/latest/generated/momepy.remove_false_nodes.html

Hi, great! We could adapt what we have in `Linearity` to get circuity I guess but if you have NumPy version already that may be faster :).

Feel free to push it as a draft PR, we can have a look as well.

Don't know, we need to revert https://github.com/pysal/momepy/commit/3dd803b566d0a048c140b3c2d1be44f4fa8fb2f8 to check.

@jonwangio Are you planning to turn this into a momepy class or do you want me to do that based on your code? See for example implementation of `SharedWallsRatio` -...

Hi, yes, you are probably right. When creating a tessellation, there are steps that may cause this mismatch. It happens mostly when you have polygons that are tiny and the...

You can try using [`momepy.preprocess`](http://docs.momepy.org/en/stable/generated/momepy.preprocess.html#momepy.preprocess) function, but keep in mind that it is highly experimental and does not always work. Split features are usually fine. I normally drop collapsed features.

> I suppose you are only interested in the 2D metrics? Not necessarily, I'd be happy to include 3D as well. I am aware that `pyvista` and `pymesh` may cause...