ENH: Simple Building Volume Density

[jonwangio]

Add BVD

[martinfleis]

@jonwangio Are you planning to turn this into a momepy class or do you want me to do that based on your code? See for example implementation of SharedWallsRatio - https://github.com/martinfleis/momepy/blob/be19ab9fb0a4daa40c82f6ac89c3920ac632df2b/momepy/distribution.py#L110

I have no problem doing that but it may take some time.

Normally, to add a new function it should be a class with a similar signature as the existing ones, with docstring and tests. I can guide you through the implementation if needed.

Just want to know what to expect with this and the other PR.

[jonwangio]

@jonwangio Are you planning to turn this into a momepy class or do you want me to do that based on your code? See for example implementation of SharedWallsRatio -

https://github.com/martinfleis/momepy/blob/be19ab9fb0a4daa40c82f6ac89c3920ac632df2b/momepy/distribution.py#L110

I have no problem doing that but it may take some time.

Normally, to add a new function it should be a class with a similar signature as the existing ones, with docstring and tests. I can guide you through the implementation if needed.

Just want to know what to expect with this and the other PR.

@martinfleis Would be great if you can turn them into what they should be for this time, and I can compare and try to mimic next time. Thanks.

[codecov[bot]]

Codecov Report

Merging #264 (be19ab9) into master (be19ab9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   96.14%   96.14%           
=======================================
  Files          12       12           
  Lines        2591     2591           
=======================================
  Hits         2491     2491           
  Misses        100      100           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be19ab9...06c1296. Read the comment docs.