momepy icon indicating copy to clipboard operation
momepy copied to clipboard

Documentation doesn't build a pdf

Open martinfleis opened this issue 4 years ago • 8 comments

RTD refuses to build a PDF because of the huge amount of numpy deprecation warnings in there (https://github.com/geopandas/geopandas/issues/2013). I have disabled the option for now but we should re-enable it once it gets fixed in geopandas 0.10.0.

martinfleis avatar Aug 10 '21 18:08 martinfleis

@martinfleis Is this fixed now?

jGaboardi avatar Apr 10 '22 13:04 jGaboardi

Don't know, we need to revert https://github.com/pysal/momepy/commit/3dd803b566d0a048c140b3c2d1be44f4fa8fb2f8 to check.

martinfleis avatar Apr 10 '22 13:04 martinfleis

we should re-enable it once it gets fixed in geopandas 0.10.0.

Since geopandas==0.10.0 has been out for a while now, I will see how this behaves now.

jGaboardi avatar Jan 08 '23 20:01 jGaboardi

Still not working. RTD is not event trying.

martinfleis avatar Jan 09 '23 10:01 martinfleis

The build is now failing, but at least it's running. Since the original problem was with the amount of numpy warning. I am 99% sure the current failure is due to the amount of pandas warnings for clip, .iloc, etc.

jGaboardi avatar Jan 09 '23 14:01 jGaboardi

Do we need a pdf at all?

martinfleis avatar Jan 09 '23 14:01 martinfleis

That's a "Martin" decision in the end. I can see value in having it for those who would like access to rich docs in a secure data center or the like (as I have desperately desired in the past), but this is certainly an edge case. I will defer to your judgment on it. Maybe we even punt for now and try again once all the pandas warnings get worked out?

jGaboardi avatar Jan 09 '23 14:01 jGaboardi

Maybe we even punt for now and try again once all the pandas warnings get worked out?

+1

not really keen spending a ton of energy on this

martinfleis avatar Jan 09 '23 14:01 martinfleis