Martin Fleischmann

Results 538 comments of Martin Fleischmann

I think that the `4.5.1` on PyPI is `4.5.1.post2` from here, because there is no other `4.5.1`. It seems that those three releases were attempts to make the GHA work.

It seems that the tag is truncated and `.post2` is actually removed before pushing it to PyPI. I just don't know why is that. It doesn't seem to be a...

Isn't this resolved by `fuzzy_contiguity`? https://pysal.org/libpysal/generated/libpysal.weights.fuzzy_contiguity.html#libpysal.weights.fuzzy_contiguity @ljwolf if we refactor `fuzzy_contiguity` based on `gdf.sindex.query_bulk`, we can expose `predicate` to easily allow `touches` and other options alongside `intersects`.

Thanks for the report! Yeah, I can confirm the behaviour. It is not an issue with `block_weights` but with `remap_ids` called under the hood to map `ids=sam1.index` onto weights. This...

The method is splot has a slightly different behaviour that the current one in libpysal. I would suggest to update first the splot one to allow similar result as we...

@revanthApricelabs can you share the data? It would help a lot when debugging this!

I can confirm the issue, using the following snippet. It doesn't even matter which distance metric is used. I'll explore the cause. ```py df = pandas.read_csv("sample_file.csv") df = geopandas.GeoDataFrame(df, geometry=geopandas.GeoSeries.from_wkt(df.geo_polygon),...

@achapkowski PR needs to be updated from master to resolve conflicts and we should add tests (based on those @ljwolf posted above).

Btw, I am not sure if this is actually tested...

> It's not okay, I'll add a test