marktoda
marktoda
Hey @snreynolds -- Can you elaborate on what needs to done here outside of https://github.com/Uniswap/sdk-core/blob/main/src/entities/ether.ts and https://github.com/Uniswap/sdk-core/blob/main/src/entities/nativeCurrency.ts?
Hey @justindomingue - thanks for reporting this, nice catch! On quick glance, it seems an easy solution would be to have `BaseCurrency` remove its dependency on `Currency` by just updating...
Thanks for submitting this! Will take a closer look later but fyi we do have gas snapshots that should be pushed to more closely assess gas changes. Preferably, each optimization...
No changes?
maybe another name would make more sense here then - `holder`?
Nice catch, thanks for looking and reporting!
replacing with https://github.com/Uniswap/v4-core/pull/440
I tested this out today, and it got a bit ugly due to lack of implicit conversions and operator overloading. Lots of `UFixed96.wrap(`, unwrap, SafeMath-esque `.add()` operators. IMO We should...
I have an idea for how to do this with forge - giving it a shot
Ah this is a cool idea -- why add `tickSpacing` on the position-level data though as it's a pool-level field (already stored in PoolKey)