v4-core
v4-core copied to clipboard
chore: fix shadowed var name
Related Issue
The parameter owner in PoolManager.getLiquidity shadows an existing state variable.
Per the contribution guidelines:
- These contracts follow the solidity style guide with one minor exception of using the _prependUnderscore style naming for internal contract functions, internal top-level parameters, and function parameters with naming collisions.
Description of changes
Prepends a _ to the offending parameter name.
maybe another name would make more sense here then - holder?
I'm with you, @marktoda . Tbh there's really no perfect system for using _.
Changed to holder, I like it, no more _
The diff is 0 lines on this PR 😆 I think it had already been fixed on main, and when you merged it in your PR became 0.
You're welcome to change it to holder if thats better - otherwise we can close this.
Closing :)