v4-core icon indicating copy to clipboard operation
v4-core copied to clipboard

chore: fix shadowed var name

Open devtooligan opened this issue 2 years ago • 3 comments
trafficstars

Related Issue

The parameter owner in PoolManager.getLiquidity shadows an existing state variable.

Per the contribution guidelines:

  1. These contracts follow the solidity style guide with one minor exception of using the _prependUnderscore style naming for internal contract functions, internal top-level parameters, and function parameters with naming collisions.

Description of changes

Prepends a _ to the offending parameter name.

devtooligan avatar Jun 14 '23 19:06 devtooligan

maybe another name would make more sense here then - holder?

marktoda avatar Jun 14 '23 22:06 marktoda

I'm with you, @marktoda . Tbh there's really no perfect system for using _.

Changed to holder, I like it, no more _

devtooligan avatar Jun 14 '23 22:06 devtooligan

The diff is 0 lines on this PR 😆 I think it had already been fixed on main, and when you merged it in your PR became 0.

You're welcome to change it to holder if thats better - otherwise we can close this.

hensha256 avatar Jun 20 '23 14:06 hensha256

Closing :)

hensha256 avatar Jun 22 '23 13:06 hensha256