sdk-core icon indicating copy to clipboard operation
sdk-core copied to clipboard

circular dependency between `Currency`, `BaseCurrency` and `NativeCurrency`

Open justindomingue opened this issue 3 years ago • 3 comments

Currency -> Native Currency -> Base Currency -> Currency

justindomingue avatar Oct 07 '21 19:10 justindomingue

Hey @justindomingue - thanks for reporting this, nice catch! On quick glance, it seems an easy solution would be to have BaseCurrency remove its dependency on Currency by just updating equals(..) to be equals(other: BaseCurrency) instead of equals(other: Currency), I think. Feel free to submit a PR to address it!

marktoda avatar Jul 06 '22 22:07 marktoda

Hey @marktoda,

Have you found a developer for this yet?

If not, I’ll add it to our site and then find a dev for you.

You wouldn’t have to fund a bounty until someone wants to fix it.

Your bounty is locked in a smart contract until you merge the dev’s PR. That releases it automatically.

Let me know if you have a budget and I’ll add it to our site.

ef3n9r98 avatar Nov 28 '22 23:11 ef3n9r98

I would like to work on this @ef3n9r98 @justindomingue

ashutosh887 avatar Jun 11 '23 10:06 ashutosh887